Rework validation of names and aliases for aggregate UDFs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
aggregate-alias-fix
branch
from
2754ee3 to
e77c437
Compare
tgross35
changed the title
tgross35
force-pushed
the
aggregate-alias-fix
branch
13 times, most recently
from
8c4a7e4 to
c2804af
Compare
Add better validation that `name = ...` and `alias = ...` line up when there is a mismatch between the `BasicUdf` and `AggregateUdf` implementation, and fix a problem that was disallowing use of aliases in aggregate UDFs. Error messages are significantly improved. Fixes <#59>
tgross35
force-pushed
the
aggregate-alias-fix
branch
from
c2804af to
8475c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better validation that
name = ...andalias = ...line up whenthere is a mismatch between the
BasicUdfandAggregateUdfimplementation, and fix a problem that was disallowing use of aliases in
aggregate UDFs.
Error messages are significantly improved.
Fixes #59